fix(adapters): carry Codex identity neutralize onto dev2-go (#638) - #665
Conversation
…#638) * fix(adapters): neutralize Codex CLI 0.145 identity wording Closes lidge-jun#622 * fix(adapters): consume full GPT-5.x.y identity versions (cherry picked from commit 868a9c4)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2815421696
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const CODEX_GPT5_IDENTITY_RE = | ||
| /You are Codex, (?:a coding agent|an agent) based on GPT-5(?:\.[0-9]+)*\./g; |
There was a problem hiding this comment.
On the dev2-go native execution path, go/internal/adapter/openai/identity.go still replaces only the historical a coding agent sentence, so requests from Codex CLI 0.145+ containing You are Codex, an agent based on GPT-5. pass upstream unchanged; these TypeScript-only changes therefore do not fix the affected runtime. Port the variant matching and regression test to the Go adapter, or retarget this TS-only patch to dev.
AGENTS.md reference: AGENTS.md:L47-L52
Useful? React with 👍 / 👎.
1 participant
Summary
dev2-go(TS oracle + tests).868a9c43ondev.Go port
Go
NeutralizeIdentitystill only exact-matchesYou are Codex, a coding agent based on GPT-5.. #638 adds the CLI 0.145an agent based on GPT-5/ optional GPT-5.x variant.Tracking issue follows. This PR does not claim the Go side is done.