Merged
Conversation
0365e6f to
277c206
Compare
shawnzhu
approved these changes
Dec 13, 2024
Contributor
shawnzhu
left a comment
There was a problem hiding this comment.
Thank you! this is a great finding
|
🎉 This PR is included in version 7.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With version 7.0.1 a query string like
?a=1&a=2&b=3would produce params likeThis change causes it to produce params like
The documentation on the API Gateway Event does not provide details on what the expected function of each of these is so I am looking for input as well as proposing one potential solution (this PR). Here are the options as I see it.
multiValueQueryStringParametersand non-array values are inqueryStringParametersqueryStringParameterseven though that would seem to go against the specserverless-httpto merge the keys that exist in bothmultiValueQueryStringParametersandqueryStringParameters, i.e. prioritize params frommultiValueQueryStringParametersThe reason for this change is that patient-service is getting events that look like this
And when the params are parsed it has the following for
ctx.queryThis causes the error because it has a tag filter with a
,which is not allowed.