Skip to content

add aws-sdk as parameter to xray helper #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jagoda merged 4 commits into from
Aug 14, 2018
Merged

add aws-sdk as parameter to xray helper #28

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e41da3d
add aws-sdk as parameter to xray helper
Aug 8, 2018
7434a83
fix build - linting errors
Aug 8, 2018
dc00aae
remove unnecessary function, reorder for tidying up code
Aug 8, 2018
37b98eb
comment explaining why we pass in client aws-sdk
Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/xray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
const xray = require('aws-xray-sdk-core');

exports.captureWithXRay = () => {
if (process.env.LAMBDA_TASK_ROOT) {
xray.captureHTTPsGlobal(require('http'));
xray.captureAWS(require('aws-sdk'));
xray.capturePromise();
}
// We are passing in the client AWS-SDK in order to avoid version conflict.
// If the calling project and lambda-tools do not agree on the AWS-SDK version then the
// caller's SDK instance will not get instrumented and there will not be any warning.
exports.captureWithXRay = function (awsSdk) {
xray.captureHTTPsGlobal(require('http'));
xray.capturePromise();
return xray.captureAWS(awsSdk);
};