This repository was archived by the owner on Aug 5, 2025. It is now read-only.
Add additional (optional) navigation tab(s)#184
Merged
Conversation
added 8 commits
May 4, 2023 11:31
cmjarreau
requested review from
aymanenadi,
bruce-glazier,
evanheisler,
markdlv and
namick
Pull Request Test Coverage Report for Build 4927071540
💛 - Coveralls |
| NotificationsTab: undefined; | ||
| SettingsTab: NavigatorScreenParams<SettingsStackParamList>; | ||
| } & { | ||
| [keyof: string]: undefined; |
Contributor
There was a problem hiding this comment.
I'm wondering if there is another way to do this where we could preserve these types without adding the equivalent of an any here. I'm not totally sure what that would be so I am approving as is.
bruce-glazier
previously approved these changes
May 9, 2023
|
|
||
| export const HelloWorldScreen = () => { | ||
| return ( | ||
| <Text style={{ paddingTop: '50%', paddingLeft: '40%' }}>Hello, world!</Text> |
Contributor
There was a problem hiding this comment.
Nit: Can you fix this warning?
bruce-glazier
approved these changes
May 9, 2023
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Screenshots