This repository was archived by the owner on Aug 5, 2025. It is now read-only.
[PE-124] Update TrackerDetails to accept reference date#229
Merged
evanheisler merged 5 commits intomasterfrom May 30, 2023
Merged
[PE-124] Update TrackerDetails to accept reference date#229evanheisler merged 5 commits intomasterfrom
evanheisler merged 5 commits intomasterfrom
Conversation
…erdetails-to-accept-date
evanheisler
requested review from
aymanenadi,
bruce-glazier,
cmjarreau,
markdlv,
namick and
sternetj
evanheisler
commented
May 26, 2023
Comment on lines
-53
to
-56
| useEffect(() => { | ||
| setDateRange(getInitialRange(dateRangeType)); | ||
| }, [dateRangeType]); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is sort of unrelated but noticed the potential here for unnecessary re-renders. I wouldn't expect this to be a prop that would change (basically just toggles between a calendar week and last 7 days) but it would fall under these conditions where useEffect isn't the best choice.
sternetj
approved these changes
May 30, 2023
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TrackerDetailsandAdvancedTrackerDetailsto receive a datereferenceDateis provided, the component uses that date instead of the current datereferenceDatein the futureknobsto storybookScreenshots
Screen.Recording.2023-05-26.at.2.46.36.PM.mov