fix: LPS-167272 Multiple events are being read in reverse order #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, nodes are accessed through keyboard navigation in chronological order. Order in DOM is irrelevant for display, positioning is absolute.
Member
|
LGTM! Only change needed is the title of the PR to follow the conventional commits pattern |
markocikos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
What is the goal of this PR?
This change fixes part of the ticket, an incorrect order of tabs in a day.
In PR, we are changing the order of nodes in DOM. With this change, nodes are accessed through keyboard navigation in chronological order. Order in DOM is irrelevant for display, as the positioning is absolute.
What does it look like?
Before PR
before.mp4
After PR
after.mp4