feat(npm-scripts): add support for multiple entry points #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaera
approved these changes
Dec 21, 2022
Member
izaera
left a comment
izaera
left a comment
There was a problem hiding this comment.
LGTM.
However, I would move the logic to test for Array to the place where the config is read, then assume that it is always an array in the other places, where you consume the data. That would save you a lot of code 👍
bryceosterhaus
force-pushed
the
multiple-entr
branch
from
533a634 to
a2054e8
Compare
Member
Author
|
@izaera good idea, I moved it to our |
Member
|
So, LGTM again 😅 |
Member
Author
|
gonna test again tomorrow and release if it works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @izaera let me know what you think about this, it seems to work fine locally for me