Skip to content

Conversation

@bryceosterhaus
Copy link
Member

@bryceosterhaus bryceosterhaus commented Jan 13, 2023

This adds a preflight check to make sure all dependencies are specified in our global osgi module.

This also allows for allow-listing certain dependencies in their npmscripts.config.js under "rules"

rules: {
    'allowed-non-global-dependencies': ['my-module']
}

An example failure looks like:
Screen Shot 2023-01-13 at 3 52 41 PM

This feature is to compliment https://issues.liferay.com/browse/LPS-168442

…e located in the global npmscripts.config.js
@izaera
Copy link
Member

izaera commented Jan 16, 2023

LGTM

@bryceosterhaus bryceosterhaus merged commit a6ad830 into liferay:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants