fix(npm-scripts): temporary work around for grabbing rules config at both the root and module level #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…both the root and module level
bryceosterhaus
force-pushed
the
master
branch
from
fc788f2 to
92591ce
Compare
Member
|
😱 |
Member
|
I've relaunched the windows test, since it looks like it could be valid 🤷 |
Member
|
It passed the test 👍 |
Member
Author
|
The windows failure was due to a async timeout. I've seen it happen before, I think it may have to just do with the machine on github actions, so I figured it would be fine to merge. Plus I like to live dangerously |
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is temporary until we provide a full solution in https://issues.liferay.com/browse/LPS-172749