Skip to content

Conversation

@izaera
Copy link
Member

@izaera izaera commented Jan 19, 2023

See https://issues.liferay.com/browse/LPS-172978.

The goal of this PR is to keep using category.remote-apps for old projects (that's detected because liferay.json is empty for them) but use category.client-extensions from now on.

Even though we are no longer using manifest.json for anything, technically,
it still has some value as documentation of what the build did and how the
artifact was configured. Thus, I'm maintaining it and adding the portlet
category name to it too.
Copy link
Member

@bryceosterhaus bryceosterhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@izaera izaera merged commit ada4e59 into liferay:master Jan 20, 2023
@izaera
Copy link
Member Author

izaera commented Jan 20, 2023

Released artifacts to npm for the three modified packages.

@dsanz
Copy link
Member

dsanz commented Jan 20, 2023

Iinm, this one does not require deps upgrade in DXP so we basically are done with this

@izaera
Copy link
Member Author

izaera commented Jan 23, 2023

we basically are done with this

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants