chore(js-toolkit): sort package.json files #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done using:
find . \
-name package.json \
-path '*/js-toolkit/*' \
-not -path '*/node_modules/*' \
-not -path '*/__tests__/*' \
-not -path '*/__fixtures/__*' \
-not -path '*/qa/samples/*' | node support/sortJSON.js
and the included helper script.
We may want to eventually integrate something like the `sortJSON.js`
script into our formatting runs, but I expect these package.json files
to stay in order for at least a while now, so I don't want to
prematurely overcomplicate things.
Test plan: Make this commit and visually inspect the changes.
Contributor
Author
|
Still not expecting this to be green; need to fix build and test for that, but this should be able to go in anyway. |
With `yarn lint:fix`.
Contributor
Author
|
As this is just a mechanical change, going to merge it and keep going from here. |
wincent
added a commit
that referenced
this pull request
Dec 18, 2020
docs(ccp): apply some copy-editing fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done using:
and the included helper script.
We may want to eventually integrate something like the
sortJSON.jsscript into our formatting runs, but I expect these package.json files to stay in order for at least a while now, so I don't want to prematurely overcomplicate things.Test plan: Make this commit and visually inspect the changes.