chore(js-toolkit): configure release messages consistently #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wincent
commented
Oct 8, 2020
wincent
commented
- Adjust existing .yarnrc files so that the release commit message matches the format used by other packages in this monorepo.
- Add .yarnrc files for packages that don't have them yet.
- Configure Lerna (still used in v2 of the js-toolkit) to produce commit messages that match the format produced by yarn; previously they produced commit messages consisting just of the bare version number (eg. see b493e10), which isn't appropriate for a multi-project monorepo.
- Adjust existing .yarnrc files so that the release commit message matches the format used by other packages in this monorepo. - Add .yarnrc files for packages that don't have them yet. - Configure Lerna (still used in v2 of the js-toolkit) to produce commit messages that match the format produced by yarn; previously they produced commit messages consisting just of the bare version number (eg. see b493e10), which isn't appropriate for a multi-project monorepo.
Contributor
Author
|
I don't think there is any good way to test the Lerna change (I don't think |
Contributor
Author
|
Going to merge this so I can try releasing. |
wincent
pushed a commit
that referenced
this pull request
Dec 18, 2020
refactor: improve actions set-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.