chore: add more lint rules #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
DXP changes needed after this PR. (there were over 1k auto-fixes 😨 )
Most of these are related to |
kresimir-coko
approved these changes
Oct 19, 2021
Member
kresimir-coko
left a comment
kresimir-coko
left a comment
There was a problem hiding this comment.
Looks great, just a couple nitpicks.
Comment on lines
20
to
22
| const argumentValue = node.arguments[0].value; | ||
| const argumentName = argumentValue.replace('data-', ''); |
Member
There was a problem hiding this comment.
Shouldn't there be an empty line inbetween these?
| * SPDX-License-Identifier: MIT | ||
| */ | ||
|
|
||
| const MESSAGE = 'Every `expect()` should assert something.'; |
Member
There was a problem hiding this comment.
Interesting that you went with capitalization here, which prevents you to imply message inside context.report
Member
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12
fixes #6
fixes #311
fixes #3
Slowly working through backlog of eslint rules we wanted to add.