deployed relay to hyperevm #1168
Conversation
|
Warning Rate limit exceeded@0xDEnYO has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 47 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughA new blockchain network configuration for "hyperevm" was added across several JSON files, including relay configuration, deployment logs, and deployment targets. The "RelayFacet" contract was deployed to this network, and its address was recorded. Additionally, a new "viction" network entry was introduced in the deployment target state. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
config/relay.json(1 hunks)deployments/_deployments_log_file.json(1 hunks)deployments/hyperevm.json(1 hunks)script/deploy/_targetState.json(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
script/deploy/_targetState.json (2)
Learnt from: ezynda3
PR: lifinance/contracts#861
File: script/deploy/_targetState.json:1453-1483
Timestamp: 2024-11-21T08:24:53.059Z
Learning: In `script/deploy/_targetState.json`, for the `abstract` network configuration, `ReceiverStargateV2` is correctly set to version `1.0.1`.
Learnt from: ezynda3
PR: lifinance/contracts#861
File: script/deploy/_targetState.json:1364-1390
Timestamp: 2024-11-21T08:25:26.214Z
Learning: For the Cronos network configuration in `script/deploy/_targetState.json`, the absence of bridge facets such as `StargateFacet`, `AcrossFacet`, `HopFacet`, and `SymbiosisFacet` is acceptable and expected.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: run-unit-tests
🔇 Additional comments (5)
deployments/hyperevm.json (2)
21-21: Fix JSON syntax by adding trailing comma
Adding a comma after the"GlacisFacet"entry ensures valid JSON so the following"RelayFacet"entry can be parsed correctly.
22-22: Verify cross-file consistency forRelayFacet
The new"RelayFacet"entry and address are formatted correctly. Please confirm this address is also reflected in related configuration and deployment target files (e.g.,config/relay.json,script/deploy/_targetState.json) and logged in the deployment records.deployments/_deployments_log_file.json (1)
32442-32456:✅ Verification successful
New “hyperevm” entry in deployments log looks correct
The JSON structure, indentation, and fields (ADDRESS, OPTIMIZER_RUNS, TIMESTAMP, CONSTRUCTOR_ARGS, SALT, VERIFIED) align with existing entries.Please verify that the “hyperevm” network has also been added consistently in the related configuration and target‐state files (
config/relay.json,deployments/hyperevm.json,script/deploy/_targetState.json).
🏁 Script executed:
#!/bin/bash # Verify 'hyperevm' network entry in related config and state files rg --color=always -n '"hyperevm"' config/relay.json deployments/hyperevm.json script/deploy/_targetState.jsonLength of output: 286
hyperevm network entries verified
- config/relay.json (line 77) contains the
"hyperevm"entry- script/deploy/_targetState.json (line 682) contains the
"hyperevm"entry- deployments/hyperevm.json is present as expected
All references to the new
hyperevmnetwork are in place and correct.config/relay.json (1)
77-81: Ensure relay configuration consistency and documentation alignment.Verify that the
chainId(999),relayReceiver(0xd71e5c1d217d12855b37fe60299273aad91d6cec), andrelaySolver(0xf70da97812CB96acDF810712Aa562db8dfA3dbEF) addresses for the newhyperevmnetwork match the official contract addresses listed in the Relay docs: https://docs.relay.link/resources/contract-addresses.script/deploy/_targetState.json (1)
704-705: Maintain consistent facet ordering and compatibility.You've added
GlacisFacetandRelayFacetto thehyperevmnetwork. Please confirm that these facet versions (1.0.0) are compatible with the network’s contracts and that their placement afterGasZipPeripheryaligns with the intended execution order.
Which Jira task belongs to this PR?
Why did I implement it this way?
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)