Skip to content

chore(emergency-pause): revert Phase 2b network narrowing — restore full networks.json#1863

Merged
0xDEnYO merged 1 commit into
mainfrom
chore/unnarrow-networks-json
May 28, 2026
Merged

chore(emergency-pause): revert Phase 2b network narrowing — restore full networks.json#1863
0xDEnYO merged 1 commit into
mainfrom
chore/unnarrow-networks-json

Conversation

@mirooon
Copy link
Copy Markdown
Contributor

@mirooon mirooon commented May 28, 2026

Which Linear task belongs to this PR?

N/A — test infrastructure revert, no Linear ticket.

Why did I implement it this way?

Reverts the narrowing of config/networks.json applied in #1829 (commit f99db16), restoring the full network list. The Phase 2b real-pause emergency-pause test on sophon / boba / rootstock has completed, so the production emergency-pause workflow must operate across all active networks again.

#1833 was the originally pre-queued revert but was closed without being merged, so this PR re-creates it from the current main state. The diff here is a pure inverse of #1829 (+1490 / −21), and config/networks.json is byte-for-byte equal to its state at commit 302c121 (the parent of the narrowing commit). No other files are touched.

⚠️ This should be merged promptly — main should not stay narrowed longer than necessary.

Checklist before requesting a review

  • I have performed a self-review of my code
  • This pull request is as small as possible and only tackles one problem
  • I have run /pr-ready (local CodeRabbit) on this branch and resolved (or explicitly documented) all findings — see .agents/commands/pr-ready.md
  • I have added tests that cover the functionality / test the bug
  • For new facets: N/A
  • I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

/pr-ready notes — deferred (pre-existing, out of scope for a pure revert)

Local CodeRabbit surfaced two minor findings; both exist verbatim at commit 302c121 (i.e. they predate #1829) and are unrelated to the emergency-pause work. Fixing them here would broaden a pure revert into config cleanup. Deferred to a follow-up PR:

  • config/networks.json:644jovay.multicallAddress is "". Real issue, but pre-existing.
  • config/networks.json:1360unichain.explorerApiUrl has a trailing ?. Real issue, but pre-existing.

…ull networks.json

Reverts the narrowing of config/networks.json applied in #1829
(commit f99db16), restoring the full network list. The Phase 2b
real-pause test on sophon/boba/rootstock has completed, so the
production emergency-pause workflow must operate across all active
networks again.
@lifi-action-bot lifi-action-bot marked this pull request as draft May 28, 2026 08:56
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 56d97eff-b46d-4460-ae8c-37438ca6ab1a

📥 Commits

Reviewing files that changed from the base of the PR and between 10a15ba and 0a16c62.

📒 Files selected for processing (1)
  • config/networks.json

Walkthrough

The PR updates config/networks.json by rewriting and expanding the network registry with standardized per-chain configuration objects containing chain IDs, RPC endpoints, block explorers, and optional metadata. Multiple new networks are added and the registry is reorganized.

Changes

Network Registry Expansion and Standardization

Layer / File(s) Summary
Core network registry standardization
config/networks.json
Network entries from mainnet through sonic are replaced with expanded per-chain configuration objects containing standardized fields (chain IDs, RPC endpoints, block explorers) and optional properties such as verification flags and developer notes.
New network entries and tail reorganization
config/networks.json
The tail section is reorganized after sophon with new chain objects inserted for stable, superposition, swellchain, taiko, telos, tempo, unichain, vana, viction, worldchain, xdc, xlayer, tron, tronshasta, and zksync; boba and rootstock entries are relocated, and localanvil remains at the end.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • lifinance/contracts#1829: Both PRs modify config/networks.json's chain registry layout—specifically changing where the boba and rootstock entries live within the file.
  • lifinance/contracts#1831: The main PR rewrites config/networks.json network registry entries that the new checkPauseStatusPerNetwork.ts script consumes to decide which networks to probe and which RPC URLs/fields to use for per-network pause checks.
  • lifinance/contracts#866: Both PRs modify config/networks.json network entries in ways that directly overlap on the underlying network registry content (including networks like taiko, xlayer, and zksync).

Suggested labels

AuditNotRequired

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reverting network narrowing to restore the full networks.json configuration for production use.
Description check ✅ Passed The description comprehensively covers the template sections with detailed context: linear task status, implementation rationale, complete checklist, reviewer notes, and explicit deferral of pre-existing issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/unnarrow-networks-json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mirooon mirooon marked this pull request as ready for review May 28, 2026 08:56
@0xDEnYO 0xDEnYO merged commit a9e1f43 into main May 28, 2026
39 of 44 checks passed
@0xDEnYO 0xDEnYO deleted the chore/unnarrow-networks-json branch May 28, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants