fix(security): fix 6 security issues in nuxt, ws - #850
Merged
Conversation
3 tasks
|
Contributor
✅ E2E Dev Smoke — passing
4 passed · 0 failed · 0 skipped · 32s |
Contributor
E2E Examples — all passedAll examples passed in the latest run. |
Contributor
E2E Playground results
Details
📥 Download full HTML report (open the run → Artifacts → |
chybisov
approved these changes
Aug 21, 2026
chybisov
added a commit
that referenced
this pull request
Aug 21, 2026
#850 added `ws@>=7.0.0 <8.0.0` and `ws@>=8.0.0` overrides but never ran `pnpm dedupe`, so the lockfile still carried ws@7.5.13 alongside ws@8.21.3. The vulnerable copy stayed in the tree via @remix-run/dev and jayson (through isomorphic-ws), which is exactly what those overrides were meant to remove — the fix was only half-applied, and `pnpm dedupe --check` failed on main. `pnpm dedupe` collapses ws to a single 8.21.3 and the check passes again.
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
Why was it implemented this way?
Explain the reasoning behind the implementation. Were there alternative approaches? Why was this solution chosen?
Upgrade Nuxt and ws to fix authorization bypass, RCE, information disclosure, memory exhaustion DoS, and arbitrary component instantiation vulnerabilities.
🤖 Remediation details
Fix GHSA-67mh-4wv8-2f99 (esbuild) and AIKIDO-2026-138234 (ws) via workspace overrides
Short summary
This PR remediates vulnerabilities in two packages —
wsandesbuild— by adding targeted overrides topnpm-workspace.yaml. Thenuxtpackage was already at a patched version (4.5.2) and required no changes. All fixes are lockfile-only; no workspace memberpackage.jsonfiles were modified.ws
wsappeared in the lockfile at three vulnerable versions:7.5.11-range instances via React Native / WalletConnect / Remix tooling parents,8.17.1viaethers@6.13.5(itself pulled in bytronweb@6.2.2←@tronweb3/tronwallet-abstract-adapter@1.2.0), and8.21.0viaethers@6.17.0,viem@2.55.19, andisows@1.0.7. Parent-chain analysis confirmed no fixing release exists for any of these immediate parents:ethers@6.17.0(latest) andviem@2.55.19(latest) both pinws@8.21.0exactly, and@tronweb3/tronwallet-abstract-adapter@1.2.0(latest) pinstronweb@6.2.2which in turn pinsws@8.17.1. Two targeted overrides were added —"ws@>=7.0.0 <8.0.0": ">=7.5.12"and"ws@>=8.0.0": ">=8.21.1"— resolving all instances tows@8.21.3(8.x) or retainingws@7.5.13(already patched at ≥ 7.5.12) for peer-dep slots that remain on the 7.x range.esbuild
esbuildappeared in the lockfile at two vulnerable versions:0.17.6(pinned exactly by@remix-run/dev@2.17.5, the latest release, and by@vanilla-extract/integration@6.5.0via annpm:esbuild@~0.17.6alias) and0.21.5(pulled in byvite@5.4.21←vite-node@1.6.1←@vanilla-extract/integration@6.5.0). No fixing release exists for either immediate parent at their latest versions, and@vanilla-extract/integration@6.5.0still depends onvite@5.xwith no newer release available. A global overrideesbuild: ">=0.25.0"was added topnpm-workspace.yaml, resolving all instances toesbuild@0.28.1.Version changes
ws8.21.08.21.3ws@>=8.0.0: >=8.21.1) — direct CVE fix;ethers@6.17.0,viem@2.55.19,isows@1.0.7pin 8.21.0 exactly with no fixing parent releasews8.17.18.21.3ws@>=8.0.0: >=8.21.1) — direct CVE fix;ethers@6.13.5←tronweb@6.2.2←@tronweb3/tronwallet-abstract-adapter@1.2.0, no fixing parent releasews7.5.137.5.13ws@>=7.0.0 <8.0.0: >=7.5.12guards against regressionesbuild0.17.60.28.1esbuild: >=0.25.0) — direct CVE fix;@remix-run/dev@2.17.5and@vanilla-extract/integration@6.5.0pin 0.17.6 with no fixing parent releaseesbuild0.21.50.28.1esbuild: >=0.25.0) — direct CVE fix;vite@5.4.21←vite-node@1.6.1←@vanilla-extract/integration@6.5.0, no fixing parent releaseVisual showcase (Screenshots or Videos)
If applicable, attach screenshots, GIFs, or videos to showcase the functionality, UI changes, or bug fixes.
Checklist before requesting a review
Security Impact — CVE vulnerabilities fixed by this PR:
✅ 6 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
vue.runtimeCompileris enabled and attacker-controlled props are forwarded to Vue's dynamic component resolution via the/__nuxt_island/endpoint. An attacker can inject a malicioustemplateproperty to execute arbitrary code within the Nitro server process./_payload.jsonwithout proper authentication checks, allowing unauthenticated or other authenticated users to access sensitive server-rendered information from cached pages.