Fix missing includes in Arch & OS headers.#724
Merged
kyle-elliott-tob merged 1 commit intolifting-bits:masterfrom Nov 19, 2025
btridev:fix-missing-cstdint
Merged
Fix missing includes in Arch & OS headers.#724kyle-elliott-tob merged 1 commit intolifting-bits:masterfrom btridev:fix-missing-cstdint
kyle-elliott-tob merged 1 commit intolifting-bits:masterfrom
btridev:fix-missing-cstdint
Conversation
|
|
kyle-elliott-tob
approved these changes
Nov 19, 2025
Collaborator
kyle-elliott-tob
left a comment
kyle-elliott-tob
left a comment
There was a problem hiding this comment.
LGTM, waiting for CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building under Linux (I run Manjaro, unsure if the distro matters), an error is raised during the compilation process in
include/remill/Arch/Name.handinclude/remill/OS/OS.h. This is caused byuint32_tnot being defined in the global scope. This pull request resolves the problem.