Check Windows defines in Name.h

[ds5678]

https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170#microsoft-specific-predefined-macros

[mrexodia]

You cannot compile remill with MSVC, so this wouldn't affect anything.

[ds5678]

You cannot compile remill with MSVC, so this wouldn't affect anything.

I already have, so it does.

[mrexodia]

Could you share more information? The codebase is littered with Clang-specific intrinsics/constructs, so this makes compiling it with MSVC rather difficult 😅

[ds5678]

I have a workflow to build static libraries of Remill.

https://github.com/ds5678/remill/actions/runs/22702765403

Whenever I referenced the static libraries on my computer, this platform detection was the only thing preventing me from using those static libraries.

[mrexodia]

Your workflow builds with clang-cl, not MSVC. But I guess you want to try to consume Remill as a library precompiled by Clang from MSVC? From what I remember there are a bunch of __attribute__((packed)) in the public headers for the State structures so it wouldn't really work?

[ds5678]

there are a bunch of attribute((packed)) in the public headers for the State structures

I do remember getting a bunch of warnings about this on my computer. I'll try again with clang-cl.

[ds5678]

there are a bunch of attribute((packed)) in the public headers for the State structures

I do remember getting a bunch of warnings about this on my computer. I'll try again with clang-cl.

I switched to clang-cl, and the warnings have disappeared. Using clang-cl also makes this pull request unnecessary. You can merge or close it.

[kyle-elliott-tob]

I think it's fine to pull in as the headers might be consumed while using a static library (if we ever get around to artifact producing CI).