Skip to content

Cross build for scala 2.13, 2.12, 2.11 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2020
Merged

Cross build for scala 2.13, 2.12, 2.11 #33

merged 3 commits into from
Jun 30, 2020

Conversation

@ohze
Copy link

@ohze ohze commented Jun 11, 2020

Fix #31

@ohze ohze marked this pull request as draft June 11, 2020 18:09
@giabao giabao force-pushed the cross branch 2 times, most recently from ece28de to e687040 Compare June 11, 2020 18:38
@ohze ohze marked this pull request as ready for review June 11, 2020 18:41
@taisukeoe
Copy link
Contributor

taisukeoe commented Jun 28, 2020

👍 for preparing cross-building rules.

I'd think it's nicer to change a sentence in README:

0.Publish the rule: publishLocal

to

0.Publish the rule: +publishLocal

(I'd think it's better to be included in this PR rather than my #34 )

@dwijnand dwijnand merged commit 3078602 into lightbend-labs:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make ExplicitNonNullaryApply work with scala 2.13

4 participants

@ohze @taisukeoe @dwijnand @giabao