specify ExplicitNonNullaryApply supported scala version in README #34
Conversation
update Scalafix version in README
make scalafix version consistent
taisukeoe
force-pushed
the
add-scala-version-caution
branch
from
aaca9bd to
7b96e29
Compare
| 2. Add SemanticDB: `addCompilerPlugin(scalafixSemanticdb)` | ||
| 3. Configure Semantic DB: `scalacOptions ++= List("-Yrangepos", "-P:semanticdb:synthetics:on")` | ||
| 4. Run the rule: `scalafix dependency:Scala213@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT` | ||
| 5. Run the rule on test sources: `Test/scalafix dependency:Scala213@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT` |
There was a problem hiding this comment.
Scala213 rule has been renamed and no longer exists.
| @@ -1,3 +1,7 @@ | |||
| # CAUTIONS! | |||
| Current released Scalafix supports ExplicitNonNullaryApply [ONLY in Scala 2.12](https://github.com/scala/scala-rewrites/issues/31). | |||
| Scalafix will support 2.13 and 2.11 with cross-building ExplicitNonNullaryApply rule against them. | |||
There was a problem hiding this comment.
As someone who doesn't quite understand the mechanics of these libraries properly, allow me to attempt to clarify.
"Scalafix v1 will allow the ExplicitNonNullaryApply rule to work and fix up code in Scala 2.11 and 2.13"
Is that correct?
There was a problem hiding this comment.
Thank you for clarification.
Is that correct?
It looks good to me except Scalafix version, depending on Scalafix release plans.
I'm not sure it will be effective only after Scalafix v1, since the PullRequest has been already merged and there might be additional v0.9.X releases.
So I'm fine with rewriting the sentence with:
"Scalafix will allow the ExplicitNonNullaryApply rule to work and fix up code in Scala 2.13"
(Considering the nature of the rule, 2.11 can be omitted)
There was a problem hiding this comment.
Of note, even coming Scalafix releases, ExplicitNonNullaryApply rule has to be cross-built by #31 PR.
There was a problem hiding this comment.
although it won't be automatic, the upcoming 0.9.18 release of sbt-scalafix (probably out tomorrow) will support running rules compiled in 2.11 and 2.13, see scalacenter/scalafix#1166 for needed steps (feedback welcome there too!)
|
@dwijnand Thank you for merging! |
4 participants
Hi, thank you for maintaining Scalafix rules to migrate easier.
I'd send this PR because:
So Scala library maintainers start trying to use ExplicitNonNullaryApply in their Scala 2.13 projects. Since its migration rule Scala version support is not obvious, it would be pitfall for them.
IMHO it should be explicitly stated in README now, and can be removed right after Scalafix next version including cross-compiled rules support is released.
Your feedback is welcome.