add openjdk11 to Travis-CI matrix #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
gah, I don't know what it currently takes to use JDK 6 on Travis, can we just drop it? |
patriknw
reviewed
Dec 7, 2018
Contributor
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
Sounds good to drop 6.
shouldn’t we use Adopt jdk?
Contributor
Author
I'm not sure if Travis has it, without extra work anyway? I'd rather not fool with it at the moment. for now it doesn't matter because Oracle hasn't stopped issuing security updates for regular OpenJDK yet |
JDK 6 is getting to be more and more of a hassle to keep supporting, why bother anymore. also drop unnecessary Scala 2.12.x versions from cross-build to keep the overall matrix size down (2.12.[012] are old, and was withdrawn)
Contributor
|
@SethTisue for reference when you need it https://github.com/akka/alpakka-kafka/pull/641/files |
raboof
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.