Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
tatianainama
force-pushed
the
08-18-feat_ai-agents_update_ai_agent_page_layout
branch
from
5c91433 to
4fdb9d1
Compare
tatianainama
force-pushed
the
08-18-feat_ai-agents_update_ai_agent_page_layout
branch
from
4fdb9d1 to
771ed8f
Compare
|
Your preview environment pr-16470 has been deployed with errors. Preview environment endpoints are available at: |
tatianainama
changed the title
tatianainama
force-pushed
the
08-18-feat_ai-agents_update_ai_agent_page_layout
branch
from
771ed8f to
e4b8a87
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| Button, | ||
| type ButtonFactory, | ||
| polymorphicFactory, | ||
| } from '@mantine-8/core'; |
There was a problem hiding this comment.
Type imports must use the type keyword for proper separation. Move type ButtonFactory to group with other type imports:
import { Button, polymorphicFactory, type ButtonFactory } from '@mantine-8/core';| Button, | |
| type ButtonFactory, | |
| polymorphicFactory, | |
| } from '@mantine-8/core'; | |
| Button, | |
| polymorphicFactory, | |
| type ButtonFactory, | |
| } from '@mantine-8/core'; |
Spotted by Diamond (based on custom rule: packages/frontend rules)
Is this helpful? React 👍 or 👎 to let us know.
| padding: var(--mantine-spacing-lg); | ||
| background: var(--mantine-color-gray-0); | ||
|
|
||
| /*Override sidebar with when collapsed, because |
There was a problem hiding this comment.
There's a small typo in the CSS comment - "sidebar with" should be "sidebar width". This appears in the explanation about the workaround for react-resizable-panels not supporting pixel-based sizing.
| /*Override sidebar with when collapsed, because | |
| /*Override sidebar width when collapsed, because |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| background: var(--mantine-color-gray-0); | ||
|
|
||
| /*Override sidebar with when collapsed, because | ||
| react-resizable-planels doesn't support pixel sizes |
There was a problem hiding this comment.
There's a typo in the comment: react-resizable-planels should be react-resizable-panels.
| react-resizable-planels doesn't support pixel sizes | |
| react-resizable-panels doesn't support pixel sizes |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-16470%22;duration=PT30M?project=lightdash-previews |
|
You can ssh into the preview environment by running: |
tatianainama
force-pushed
the
08-18-feat_ai-agents_update_ai_agent_page_layout
branch
from
e4b8a87 to
0b93363
Compare
| useEffect(() => { | ||
| const timer = setInterval(updateCollapsedState, 100); | ||
| return () => clearInterval(timer); | ||
| }, []); |
There was a problem hiding this comment.
The useEffect hook uses setInterval with a 100ms polling interval to check sidebar collapse state, which violates Frontend performance rules. This creates unnecessary frequent re-renders and function calls that could impact performance. Consider using event-driven approaches like onResize callbacks from the react-resizable-panels library, or use a more reasonable polling interval (e.g., 500ms or higher) if polling is absolutely necessary.
Spotted by Diamond (based on custom rule: packages/frontend rules)
Is this helpful? React 👍 or 👎 to let us know.
Merge activity
|
tatianainama
deleted the
08-18-feat_ai-agents_update_ai_agent_page_layout
branch
# [0.1939.0](0.1938.1...0.1939.0) (2025-08-20) ### Features * Update AI Agent Page layout ([#16470](#16470)) ([6dfe4a1](6dfe4a1))
|
🎉 This PR is included in version 0.1939.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Updated the AI Agent Page Layout with collapsible sidebar functionality. - Sidebar is collapsible now, can be done by the new toggle button or using the panel resize handle - Moved the agent selector to new header section - Moved settings and new agent creation into a menu in header section [Screen Recording 2025-08-19 at 09.38.38.mov <span class="graphite__hidden">(uploaded via Graphite)</span> <img class="graphite__hidden" src="https://app.graphite.dev/user-attachments/thumbnails/4782e419-ea3f-4c69-8a78-fa76b5e4b4e6.mov" />](https://app.graphite.dev/user-attachments/video/4782e419-ea3f-4c69-8a78-fa76b5e4b4e6.mov)
# [0.1939.0](lightdash/lightdash@0.1938.1...0.1939.0) (2025-08-20) ### Features * Update AI Agent Page layout ([lightdash#16470](lightdash#16470)) ([6dfe4a1](lightdash@6dfe4a1))
3 participants
Updated the AI Agent Page Layout with collapsible sidebar functionality.
Screen Recording 2025-08-19 at 09.38.38.mov (uploaded via Graphite)