Skip to content

feat: Introduce artifact panel#16493

Merged
tatianainama merged 1 commit intomainfrom
08-19-feat_introduce_artifact_panel
Aug 20, 2025
Merged

feat: Introduce artifact panel#16493
tatianainama merged 1 commit intomainfrom
08-19-feat_introduce_artifact_panel

Conversation

@tatianainama
Copy link
Copy Markdown
Contributor

@tatianainama tatianainama commented Aug 19, 2025

Description:

Added artifact panel to AI Agent Page Layout. This panel will be used to display artifacts alongside the chat.
I've also:

  • Removed some unnecessary ref from the page layout component
  • Added artifact imperative functions to context
  • Automatic collapse sidebar when artifacts displayed

Screen Recording 2025-08-19 at 16.52.50.mov (uploaded via Graphite)

Next

  • Display visualizations correctly in new artifact panel
  • Animations and interactions improvements

Copy link
Copy Markdown
Contributor Author

tatianainama commented Aug 19, 2025

@github-actions
Copy link
Copy Markdown

Your preview environment pr-16493 has been deployed with errors.

Comment on lines +50 to +53
useEffect(() => {
const timer = setInterval(updateCollapsedState, 100);
return () => clearInterval(timer);
}, []);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-resizable-panels doesn't have a reactive way of knowing if a panel is collapsed, so this adds a timer that checks and updates the state 🫠

@tatianainama tatianainama changed the base branch from 08-18-feat_ai-agents_update_ai_agent_page_layout to graphite-base/16493 August 20, 2025 15:22
@tatianainama tatianainama force-pushed the 08-19-feat_introduce_artifact_panel branch from 7e7b6bd to 5bf7fb3 Compare August 20, 2025 15:24
@graphite-app graphite-app bot changed the base branch from graphite-base/16493 to main August 20, 2025 15:25
@tatianainama tatianainama force-pushed the 08-19-feat_introduce_artifact_panel branch from 5bf7fb3 to ddd669e Compare August 20, 2025 15:25
Copy link
Copy Markdown
Contributor Author

tatianainama commented Aug 20, 2025

Merge activity

  • Aug 20, 4:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 20, 4:38 PM UTC: @tatianainama merged this pull request with Graphite.

@tatianainama tatianainama merged commit 3cae21b into main Aug 20, 2025
20 of 22 checks passed
@tatianainama tatianainama deleted the 08-19-feat_introduce_artifact_panel branch August 20, 2025 16:38
lightdash-bot pushed a commit that referenced this pull request Aug 20, 2025
# [0.1942.0](0.1941.0...0.1942.0) (2025-08-20)

### Bug Fixes

* scheduled delivery filter revert state ([#16500](#16500)) ([0d1e977](0d1e977))
* table calcs changing names when edited ([#16508](#16508)) ([3b4f063](3b4f063))

### Features

* Introduce artifact panel ([#16493](#16493)) ([3cae21b](3cae21b))
@lightdash-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 0.1942.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

magnew pushed a commit that referenced this pull request Aug 25, 2025
<!-- Thanks so much for your PR, your contribution is appreciated! ❤️ -->

### Description:
Added artifact panel to AI Agent Page Layout. This panel will be used to display artifacts alongside the chat.
I've also:
- Removed some unnecessary ref from the page layout component
- Added artifact imperative functions to context
- Automatic collapse sidebar when artifacts displayed

[Screen Recording 2025-08-19 at 16.52.50.mov <span class="graphite__hidden">(uploaded via Graphite)</span> <img class="graphite__hidden" src="https://app.graphite.dev/user-attachments/thumbnails/f58e48f4-e0c2-42e1-a696-8e843f716696.mov" />](https://app.graphite.dev/user-attachments/video/f58e48f4-e0c2-42e1-a696-8e843f716696.mov)

### Next
- Display visualizations correctly in new artifact panel
- Animations and interactions improvements
magnew pushed a commit to Abhijay007/lightdash that referenced this pull request Aug 25, 2025
# [0.1942.0](lightdash/lightdash@0.1941.0...0.1942.0) (2025-08-20)

### Bug Fixes

* scheduled delivery filter revert state ([lightdash#16500](lightdash#16500)) ([0d1e977](lightdash@0d1e977))
* table calcs changing names when edited ([lightdash#16508](lightdash#16508)) ([3b4f063](lightdash@3b4f063))

### Features

* Introduce artifact panel ([lightdash#16493](lightdash#16493)) ([3cae21b](lightdash@3cae21b))
@sentry
Copy link
Copy Markdown

sentry bot commented Aug 27, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants