Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Your preview environment pr-16493 has been deployed with errors. |
notgiorgi
approved these changes
Aug 20, 2025
Comment on lines
+50
to
+53
| useEffect(() => { | ||
| const timer = setInterval(updateCollapsedState, 100); | ||
| return () => clearInterval(timer); | ||
| }, []); |
Contributor
Author
There was a problem hiding this comment.
react-resizable-panels doesn't have a reactive way of knowing if a panel is collapsed, so this adds a timer that checks and updates the state 🫠
7e7b6bd to
5bf7fb3
Compare
0b93363 to
6dfe4a1
Compare
5bf7fb3 to
ddd669e
Compare
ddd669e to
5ecd1a0
Compare
Contributor
Author
Merge activity
|
lightdash-bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
# [0.1942.0](0.1941.0...0.1942.0) (2025-08-20) ### Bug Fixes * scheduled delivery filter revert state ([#16500](#16500)) ([0d1e977](0d1e977)) * table calcs changing names when edited ([#16508](#16508)) ([3b4f063](3b4f063)) ### Features * Introduce artifact panel ([#16493](#16493)) ([3cae21b](3cae21b))
Collaborator
|
🎉 This PR is included in version 0.1942.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Aug 21, 2025
magnew
pushed a commit
that referenced
this pull request
Aug 25, 2025
<!-- Thanks so much for your PR, your contribution is appreciated! ❤️ --> ### Description: Added artifact panel to AI Agent Page Layout. This panel will be used to display artifacts alongside the chat. I've also: - Removed some unnecessary ref from the page layout component - Added artifact imperative functions to context - Automatic collapse sidebar when artifacts displayed [Screen Recording 2025-08-19 at 16.52.50.mov <span class="graphite__hidden">(uploaded via Graphite)</span> <img class="graphite__hidden" src="https://app.graphite.dev/user-attachments/thumbnails/f58e48f4-e0c2-42e1-a696-8e843f716696.mov" />](https://app.graphite.dev/user-attachments/video/f58e48f4-e0c2-42e1-a696-8e843f716696.mov) ### Next - Display visualizations correctly in new artifact panel - Animations and interactions improvements
magnew
pushed a commit
to Abhijay007/lightdash
that referenced
this pull request
Aug 25, 2025
# [0.1942.0](lightdash/lightdash@0.1941.0...0.1942.0) (2025-08-20) ### Bug Fixes * scheduled delivery filter revert state ([lightdash#16500](lightdash#16500)) ([0d1e977](lightdash@0d1e977)) * table calcs changing names when edited ([lightdash#16508](lightdash#16508)) ([3b4f063](lightdash@3b4f063)) ### Features * Introduce artifact panel ([lightdash#16493](lightdash#16493)) ([3cae21b](lightdash@3cae21b))
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
Added artifact panel to AI Agent Page Layout. This panel will be used to display artifacts alongside the chat.
I've also:
Screen Recording 2025-08-19 at 16.52.50.mov (uploaded via Graphite)
Next