Skip to content

fix: scheduled delivery filter revert state#16500

Merged
magnew merged 1 commit intomainfrom
08-15-fix_scheduled_delivery_filter_revert_state
Aug 20, 2025
Merged

fix: scheduled delivery filter revert state#16500
magnew merged 1 commit intomainfrom
08-15-fix_scheduled_delivery_filter_revert_state

Conversation

@magnew
Copy link
Copy Markdown
Contributor

@magnew magnew commented Aug 19, 2025

Description:

Fix scheduled delivery filter revert for 'any value' filters. Scheduler filters with 'any value' weren't reverting properly since the UI in Scheduled deliveries doesn't include enable/disable.

This makes it so that if a fitler that requires values has no values, it gets set to disabled.

To see the original issue:

  • Add a filter with 'any value' to a dashboard
  • Create a scheduled delivery and go to the filters tab
  • Give the filter a value
  • Revert it
  • It gets set to no value, but not 'any value'

Bug:
Kapture 2025-08-19 at 18 33 38

The fitler is now in a state of being enabled with no values. This fix enables and disables the filters based on values and operator.

Fixed:
after

Copy link
Copy Markdown
Contributor Author

magnew commented Aug 19, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@magnew magnew marked this pull request as ready for review August 19, 2025 16:27
@magnew magnew requested a review from a team August 19, 2025 16:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 19, 2025

Your preview environment pr-16500 has been deployed.

Preview environment endpoints are available at:

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

You can ssh into the preview environment by running: ./scripts/okteto-ssh.sh 16500

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

You can ssh into the preview environment by running: ./scripts/okteto-ssh.sh 16500

Copy link
Copy Markdown
Contributor

@almeidabbm almeidabbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@magnew magnew merged commit 0d1e977 into main Aug 20, 2025
81 of 88 checks passed
@magnew magnew deleted the 08-15-fix_scheduled_delivery_filter_revert_state branch August 20, 2025 16:38
lightdash-bot pushed a commit that referenced this pull request Aug 20, 2025
# [0.1942.0](0.1941.0...0.1942.0) (2025-08-20)

### Bug Fixes

* scheduled delivery filter revert state ([#16500](#16500)) ([0d1e977](0d1e977))
* table calcs changing names when edited ([#16508](#16508)) ([3b4f063](3b4f063))

### Features

* Introduce artifact panel ([#16493](#16493)) ([3cae21b](3cae21b))
@lightdash-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 0.1942.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

magnew pushed a commit that referenced this pull request Aug 25, 2025
# [0.1942.0](0.1941.0...0.1942.0) (2025-08-20)

### Bug Fixes

* scheduled delivery filter revert state ([#16500](#16500)) ([0d1e977](0d1e977))
* table calcs changing names when edited ([#16508](#16508)) ([3b4f063](3b4f063))

### Features

* Introduce artifact panel ([#16493](#16493)) ([3cae21b](3cae21b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants