feat(chart-types): allow linking external connections - #28136
Merged
Conversation
Contributor
🛡️ Upgrade safety for self-hosted customers
What we looked at
Technical details (raw JSON){
"schemaVersion": "2",
"version": "pr-28136",
"previousVersion": "4ddd02c84a",
"releaseDate": "2026-08-27T16:30:20.152Z",
"migrations": {
"present": false,
"count": 0,
"coreCount": 0,
"eeCount": 0,
"files": []
},
"compatibility": {
"rollingUpdateSafe": true,
"recommendedStrategy": "RollingUpdate"
},
"api": {
"rest": {
"checked": true,
"breaking": false,
"changes": [],
"breakingCount": 0,
"advisories": [],
"advisoryCount": 0
},
"mcp": {
"checked": true,
"breaking": false,
"changes": [],
"breakingCount": 0,
"advisories": [],
"advisoryCount": 0
}
},
"config": {
"checked": true,
"breaking": false,
"changes": []
},
"upgrade": {
"minPreviousVersion": null,
"requiredStops": []
},
"declaredBreaks": []
}Automated upgrade-safety check. Once merged, it ships a small |
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-28136 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-28136.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
cursor
Bot
force-pushed
the
cursor/chart-type-external-connections-315c
branch
from
August 27, 2026 08:26
1802b2a to
09eac00
Compare
almeidabbm
marked this pull request as ready for review
August 27, 2026 14:07
Custom chart types can now attach project external connections, the same way data apps already do. Linking a connection with public images enabled adds its origin to the sandbox CSP so image URL fields can render. The builder header manages links on an existing type without a rebuild. The composer still sends connections on generate and iterate so the build agent sees them. Co-authored-by: Bruno Almeida <almeidabbm@users.noreply.github.com>
The GET returns alias plus the connection, not the write-body uuid/alias pair. Co-authored-by: Bruno Almeida <almeidabbm@users.noreply.github.com>
The typecheck fix landed, but Actions did not start a new pull_request run. Co-authored-by: Bruno Almeida <almeidabbm@users.noreply.github.com>
Co-authored-by: Bruno Almeida <almeidabbm@users.noreply.github.com>
Co-authored-by: Bruno Almeida <almeidabbm@users.noreply.github.com>
Co-authored-by: Bruno Almeida <almeidabbm@users.noreply.github.com>
Co-authored-by: Bruno Almeida <almeidabbm@users.noreply.github.com>
Co-authored-by: Bruno Almeida <almeidabbm@users.noreply.github.com>
Co-authored-by: Bruno Almeida <almeidabbm@users.noreply.github.com>
The trigger tooltip rendered on top of the open picker and covered its Done button, so the popover could not be closed from the footer. Cancelling the clarifier only handed the prompt back, silently dropping the attached connections. After a first build the picker gave no sign of which connections were already linked, and the app-links hook was typed against the link request body rather than the read shape the list endpoint returns. The description no longer leads with public images: linking is the feature, images are one use of it.
almeidabbm
force-pushed
the
cursor/chart-type-external-connections-315c
branch
from
August 27, 2026 16:21
201ebe3 to
3327c20
Compare
After a first build the indicator dropped back to nothing, although the connections just linked were still attached to the chart type. Linked and newly selected connections now count together, and the count refreshes when a build lands.
Collaborator
|
🎉 This PR is included in version 2.37.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #28056
Closes: PROD-10583
Description:
Custom chart types render in the same sandboxed iframe as data apps, so images from URL fields are blocked by CSP unless the chart type is linked to an external connection with "Allow public images in linked apps". The chart type builder had no way to attach those connections.
This PR adds connection attachment to the custom chart type generate/iterate flow, matching data apps. The backend already accepted
externalConnectionson generate/iterate and already injected linked origins into the preview-token CSP.chart-type-build-only-connection-attach.mp4
Risk assessment: