Skip to content

fix: reconcile repository MIT licensing (#132)#145

Merged
litroc merged 9 commits into
developfrom
agent/issue-132-governance-license
Jul 27, 2026
Merged

fix: reconcile repository MIT licensing (#132)#145
litroc merged 9 commits into
developfrom
agent/issue-132-governance-license

Conversation

@litroc

@litroc litroc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • normalize all first-party repository declarations and repository-native asset records to the MIT license recorded in LICENSE, GitHub repository metadata, and managed .lit/repository.yml
  • add a deterministic repository-license validator to the existing license gate
  • retain the existing third-party dependency inventory and generated attribution flow unchanged

Root cause and impact

The repository license and GitHub metadata were already MIT, but package metadata, the README license paragraph, and contributor guidance still declared Apache-2.0. This change removes that governance ambiguity and makes future mismatches fail CI.

The managed .lit/repository.yml remains unchanged and continues to be owned by lightning-it/shared-assets-lit.

Evidence

  • GitHub repository license metadata: MIT
  • first-party consistency check: passed
  • synthetic Apache-2.0 mismatch fixture: rejected as expected
  • dependency license inventory: reviewed 2,006 installed packages and retained 671 unique attribution texts
  • third-party NOTICE publication: passed during the production build
  • unit and validation tests: 21 Vitest tests and 55 Node validation tests passed
  • static site: 97 HTML files, 95 canonical routes, and 5,807 first-party references validated
  • browser checks: 40 Playwright tests passed
  • Lighthouse: budgets passed for three representative routes
  • audits: zero high-severity vulnerabilities in full and production dependency sets

The architecture baseline now records the implementation transition without retaining an active conflicting license value. The approval validator consequently continues to fail closed until issue #2 supplies exact-tree, role-matched approval; this is the independent production-publication gate and is not bypassed by this PR.

Rollback

Revert this PR. No dependency versions, third-party license texts, managed assets, credentials, DNS, or production configuration are changed.

Closes #132

@litroc
litroc marked this pull request as ready for review July 27, 2026 02:44
@litroc
litroc requested a review from litdeg as a code owner July 27, 2026 02:44
Copilot AI review requested due to automatic review settings July 27, 2026 02:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reconciles first-party license declarations across the repository to match the authoritative MIT license (as declared in LICENSE, GitHub metadata, and .lit/repository.yml) and adds a deterministic CI validator to prevent future drift.

Changes:

  • Normalize first-party MIT declarations in package.json, package-lock.json, README.md, and CONTRIBUTING.md.
  • Add a new first-party repository license consistency validator + node:test coverage.
  • Wire the new validator into the existing test:licenses gate while keeping the third-party license flow intact.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/lib/repository-license.mjs Implements a deterministic validator that checks key first-party MIT declarations.
scripts/lib/repository-license.test.mjs Adds node:test coverage for consistent and mismatched license declarations.
scripts/check-repository-license.mjs Adds a CLI entrypoint that reads repo files and runs the validator during CI/license checks.
package.json Switches license to MIT and runs the new validator as part of test:licenses.
package-lock.json Updates the lockfile root package license to MIT for consistency.
README.md Updates the License section to declare MIT (matching LICENSE and badges).
CONTRIBUTING.md Updates contributor licensing language to MIT.

Comment thread scripts/lib/repository-license.mjs Outdated
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploying lightning-it-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: d9c8d41
Status: ✅  Deploy successful!
Preview URL: https://448ac812.lightning-it-documentation.pages.dev
Branch Preview URL: https://agent-issue-132-governance-l.lightning-it-documentation.pages.dev

View logs

Copilot AI review requested due to automatic review settings July 27, 2026 02:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Comment thread package.json
Copilot AI review requested due to automatic review settings July 27, 2026 02:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Comment thread scripts/lib/repository-license.mjs
Comment thread docs/architecture/governance-release-licensing-baseline.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Comment thread scripts/validate-content.mjs Outdated
Copilot AI review requested due to automatic review settings July 27, 2026 04:06
@github-actions
github-actions Bot disabled auto-merge July 27, 2026 04:06
@github-actions
github-actions Bot disabled auto-merge July 27, 2026 04:06
@litroc
litroc enabled auto-merge July 27, 2026 04:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Comment thread scripts/lib/asset-provenance.mjs Outdated
Copilot AI review requested due to automatic review settings July 27, 2026 04:11
@github-actions
github-actions Bot disabled auto-merge July 27, 2026 04:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Comment thread scripts/check-repository-license.mjs
Copilot AI review requested due to automatic review settings July 27, 2026 04:15
@github-actions
github-actions Bot disabled auto-merge July 27, 2026 04:15
@litroc
litroc enabled auto-merge July 27, 2026 04:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Comment thread scripts/validate-content.mjs Outdated
Comment thread scripts/lib/asset-provenance.mjs Outdated
Copilot AI review requested due to automatic review settings July 27, 2026 04:19
@github-actions
github-actions Bot disabled auto-merge July 27, 2026 04:20
@litroc
litroc enabled auto-merge July 27, 2026 04:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Comment thread scripts/validate-content.mjs
Copilot AI review requested due to automatic review settings July 27, 2026 04:23
@github-actions
github-actions Bot disabled auto-merge July 27, 2026 04:23
@litroc
litroc enabled auto-merge July 27, 2026 04:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.

@litroc
litroc merged commit 6835c61 into develop Jul 27, 2026
13 checks passed
@litroc
litroc deleted the agent/issue-132-governance-license branch July 27, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implementation: reconcile repository governance and licensing

2 participants