Skip to content

fix: subTexture in canvas renderer #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix: subTexture in canvas renderer #501

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aba68a
fix: subTexture in canvas renderer
pecoram Jan 24, 2025
bd5353a
fx: removed hasImage check
pecoram Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/core/renderers/canvas/CanvasCoreRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,11 @@ export class CanvasCoreRenderer extends CoreRenderer {
const textureType = texture?.type;
assertTruthy(textureType, 'Texture type is not defined');

// The Canvas2D renderer only supports image and color textures
// The Canvas2D renderer only supports image and color textures and subTexture images
if (
textureType !== TextureType.image &&
textureType !== TextureType.color
textureType !== TextureType.color &&
textureType !== TextureType.subTexture
) {
return;
}
Expand Down Expand Up @@ -185,7 +186,11 @@ export class CanvasCoreRenderer extends CoreRenderer {
ctx.clip(path);
}

if (textureType === TextureType.image && ctxTexture) {
if (
(textureType === TextureType.image ||
textureType === TextureType.subTexture) &&
ctxTexture
) {
const image = ctxTexture.getImage(color);
ctx.globalAlpha = color.a ?? alpha;
if (frame) {
Expand Down
Loading