perf: dirty quad buffer with surgical bufferSubData uploads - #861
Merged
wouterlucas merged 2 commits intoAug 7, 2026
Conversation
jfboeve
previously approved these changes
Aug 7, 2026
wouterlucas
dismissed
jfboeve’s stale review
August 7, 2026 10:14
The merge-base changed after approval.
jfboeve
previously approved these changes
Aug 7, 2026
wouterlucas
dismissed
jfboeve’s stale review
August 7, 2026 10:19
The merge-base changed after approval.
jfboeve
previously approved these changes
Aug 7, 2026
wouterlucas
dismissed
jfboeve’s stale review
August 7, 2026 10:39
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimizes the per-frame quad upload in the WebGL renderer so that only the quads that actually changed are re-uploaded to the GPU, instead of uploading the entire quad buffer on every frame.
How it works
quadBufferIndex) in the quad buffer, assigned contiguously during theaddQuadpass.isQuadDirty) inCoreNode.update().render(), the renderer chooses between:gl.bufferSubDataper dirty node, copying each 20-float quad into a preallocated scratch buffer (no per-frame allocation).gl.bufferDatawhen the render list changes structurally, the buffer grows, or more than 40% of the render list is dirty (NbufferSubDatacalls are more expensive than one bulk upload at that point).Stage.requestRenderListUpdate()notifies the renderer (invalidateQuadBuffer()) on structural changes so slots are reset and everything is re-uploaded.Changes
src/core/CoreNode.ts—quadBufferIndex/isQuadDirtybookkeeping + dirty markingsrc/core/Stage.ts— expose render list; callrenderer.invalidateQuadBuffer()on rebuildssrc/core/platforms/GlContextWrapper.ts,WebGlContextWrapper.ts—arrayBufferSubDatasrc/core/renderers/CoreRenderer.ts— optionalinvalidateQuadBuffer()hooksrc/core/renderers/webgl/WebGlRenderer.ts— dirty-ratio upload decision, surgicalbufferSubData, dedicated RTT bufferCoreNode.test.ts,Stage.renderListUpdate.test.ts,WebGlRenderer.dirtyQuadBuffer.test.tsexamples/tests/dirty-quad-buffer.ts+ certified snapshots (covers move, color, alpha, RTT child move, add, remove)Verification
pnpm buildpassespnpm vitest run— 509/509 tests passpnpm lintclean