lexe lightning address

[ntheile]

Summary by CodeRabbit

• New Features

  • Added access to a wallet’s human-readable Bitcoin address, Lightning address, payment offer, and update status.
  • Exposed the new address information through the React Native interface.

• Documentation

  • Updated usage examples and package information for version 0.2.18.

• Tests

  • Added coverage verifying all returned address details.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR adds human Bitcoin address retrieval to the Lexe Rust API and React Native bindings. It exposes Bitcoin address, Lightning address, offer, and updateability fields, adds backend and binding tests, and updates package documentation to version 0.2.18.

Changes

Human Bitcoin Address Retrieval

Layer / File(s)	Summary
Backend address API crates/lni/..., crates/lni/Cargo.toml	The Lexe backend defines and exports LexeHumanBitcoinAddress, retrieves the data from the wallet API, maps errors, and tests the returned fields.
React Native native bridge bindings/react-native-lexe/rust/src/lib.rs, bindings/react-native-lexe/src/LexeLniNode.ts	The native and TypeScript bindings expose getHumanBitcoinAddress() and convert all address fields.
React Native validation and release metadata bindings/react-native-lexe/src/__tests__/*, bindings/react-native-lexe/README.md, bindings/react-native-lexe/package.json	Tests verify the returned address data. Documentation and package metadata use version 0.2.18.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ReactNativeCaller
  participant LexeLniNode
  participant NativeLexeNode
  participant LexeAPI
  ReactNativeCaller->>LexeLniNode: getHumanBitcoinAddress()
  LexeLniNode->>NativeLexeNode: get_human_bitcoin_address()
  NativeLexeNode->>LexeAPI: get_human_bitcoin_address
  LexeAPI-->>NativeLexeNode: Address and payment metadata
  NativeLexeNode-->>LexeLniNode: HumanBitcoinAddress
  LexeLniNode-->>ReactNativeCaller: LexeHumanBitcoinAddress

Loading

Possibly related PRs

• lightning-node-interface/lni#21: Adds related Spark integration used by the underlying LNI APIs.
• lightning-node-interface/lni#50: Introduces LexeNode APIs extended by this address retrieval API.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 22.22% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the added Lexe lightning address functionality, which is a central part of the changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch lexe-lightning-address

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		Obfuscated code: cargo lexe-common is 90.0% likely obfuscated Confidence: 0.90 Location: Package overview From: ? → cargo/lexe-common@0.1.19 ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore cargo/lexe-common@0.1.19. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		Obfuscated code: cargo lexe-tls is 90.0% likely obfuscated Confidence: 0.90 Location: Package overview From: ? → cargo/lexe-tls@0.1.19 ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore cargo/lexe-tls@0.1.19. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bindings/react-native-lexe/package.json`:
- Line 3: Update the version in bindings/react-native-lexe/package.json from
0.2.18 to match the published core package versions, including `@sunnyln/lni`,
`@sunnyln/lni-arkade`, and `@sunnyln/lni-spark` at 0.2.20; only retain the current
version if the release divergence is explicitly documented.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b290385-06a2-4b8e-9ab0-4494282466a2

📥 Commits

Reviewing files that changed from the base of the PR and between bb7ac90 and d7c1ffe.

⛔ Files ignored due to path filters (5)

• Cargo.lock is excluded by !**/*.lock
• bindings/react-native-lexe/cpp/generated/react_native_lexe.cpp is excluded by !**/generated/**
• bindings/react-native-lexe/cpp/generated/react_native_lexe.hpp is excluded by !**/generated/**
• bindings/react-native-lexe/src/generated/react_native_lexe-ffi.ts is excluded by !**/generated/**
• bindings/react-native-lexe/src/generated/react_native_lexe.ts is excluded by !**/generated/**

📒 Files selected for processing (9)

• bindings/react-native-lexe/README.md
• bindings/react-native-lexe/package.json
• bindings/react-native-lexe/rust/src/lib.rs
• bindings/react-native-lexe/src/LexeLniNode.ts
• bindings/react-native-lexe/src/__tests__/LexeLniNode.test.ts
• crates/lni/Cargo.toml
• crates/lni/lexe/api.rs
• crates/lni/lexe/lib.rs
• crates/lni/lib.rs