Conversation
Member
|
Nice, brian-brazil left some good recommendations on your PR:
I'll open an issue as they would be a great fit for a follow-up |
We registered port 9750 the [port allocation] list for the prometheus project, so we should use that port :-) Suggested-by: Martin Milata <@mmilata> [port allocation]: https://github.com/prometheus/prometheus/wiki/Default-port-allocations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We registered port 9750 the [port allocation] list for the prometheus project,
so we should use that port :-)
The addition to the list of known exporters is still pending prometheus/docs#1737
Suggested-by: Martin Milata <@mmilata>
Fixes #122
[port allocation]: https://github.com/prometheus/prometheus/wiki/Default-port-allocations