Skip to content

prometheus: Change default port to 9750 as per port-allocation#138

Merged
cdecker merged 1 commit intomasterfrom
issue-122
Aug 29, 2020
Merged

prometheus: Change default port to 9750 as per port-allocation#138
cdecker merged 1 commit intomasterfrom
issue-122

Conversation

@cdecker
Copy link
Contributor

@cdecker cdecker commented Aug 28, 2020

We registered port 9750 the [port allocation] list for the prometheus project,
so we should use that port :-)

The addition to the list of known exporters is still pending prometheus/docs#1737

Suggested-by: Martin Milata <@mmilata>
Fixes #122
[port allocation]: https://github.com/prometheus/prometheus/wiki/Default-port-allocations

@darosior
Copy link
Member

Nice, brian-brazil left some good recommendations on your PR:

Some suggestions to improve your exporter:
_total is a suffix for counters, it shouldn't be used with gauges. Some metrics like lightning_channel_in_msatoshi_offered also sound like they might be counters rather than gauges.
Units are inconsistent, sometimes missing and conflicting with the help text. You should consistently use satoshis, and also include satoshi as the unit in all relevant metric names for clarity.
id is a bit of a generic label, peer or peer_id would be clearer.

I'll open an issue as they would be a great fit for a follow-up

Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

We registered port 9750 the [port allocation] list for the prometheus project,
so we should use that port :-)

Suggested-by: Martin Milata <@mmilata>

[port allocation]: https://github.com/prometheus/prometheus/wiki/Default-port-allocations
@cdecker cdecker merged commit 9f3ac44 into master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advertise prometheus plugin

2 participants