Noticed while reviewing 613, it looks like if we do an RGS sync, get an update, apply it to the graph, then write the latest_rgs_snapshot_timestamp metric, then crash (skipping the NetworkGraph persist in the LDK Background Processor shutdown logic) we will lose some updates. On startup we'll sync from the latest_rgs_snapshot_timestamp metric rather than using https://docs.rs/lightning/latest/lightning/routing/gossip/struct.NetworkGraph.html#method.get_last_rapid_gossip_sync_timestamp leading to us simply losing the updates that were in the RGS update we previously synced. Not exactly critical, but might be worth using the NetworkGraph one.
Noticed while reviewing 613, it looks like if we do an RGS sync, get an update, apply it to the graph, then write the
latest_rgs_snapshot_timestampmetric, then crash (skipping theNetworkGraphpersist in the LDK Background Processor shutdown logic) we will lose some updates. On startup we'll sync from thelatest_rgs_snapshot_timestampmetric rather than using https://docs.rs/lightning/latest/lightning/routing/gossip/struct.NetworkGraph.html#method.get_last_rapid_gossip_sync_timestamp leading to us simply losing the updates that were in the RGS update we previously synced. Not exactly critical, but might be worth using theNetworkGraphone.