Add CI job to verify generated protobuf files are up to date#153
Merged
benthecarman merged 1 commit intolightningdevkit:mainfrom Mar 17, 2026
Merged
Add CI job to verify generated protobuf files are up to date#153benthecarman merged 1 commit intolightningdevkit:mainfrom
benthecarman merged 1 commit intolightningdevkit:mainfrom
Conversation
Runs proto generation and checks for uncommitted diffs whenever files in ldk-server-protos/ are changed. Now we will know if the generated files were correctly updated when we edit the protobufs. This found a formatting issue in the types.rs for me. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
👋 Thanks for assigning @joostjager as a reviewer! |
joostjager
approved these changes
Mar 17, 2026
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout source code | ||
| uses: actions/checkout@v3 |
Contributor
There was a problem hiding this comment.
Quite a few diff checkout actions are used across the workflows in this repo. Newest used is v5.
Collaborator
Author
There was a problem hiding this comment.
I am just going to do this in a follow up in the future since we are using different ones across multiple
| run: | | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable | ||
| - name: Install protoc | ||
| run: sudo apt-get install -y protobuf-compiler |
Contributor
There was a problem hiding this comment.
Not sure how important version pinning is here? It would be nice to know what to use locally perhaps.
Collaborator
Author
There was a problem hiding this comment.
you just need a version >3.15 of protoc which basically all modern systems have
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs proto generation and checks for uncommitted diffs whenever files in ldk-server-protos/ are changed. Now we will know if the generated files were correctly updated when we edit the protobufs.
This found a formatting issue in the types.rs for me.