Add unified payment send support#161
Merged
valentinewallace merged 1 commit intolightningdevkit:mainfrom Mar 20, 2026
Merged
Conversation
|
I've assigned @valentinewallace as a reviewer! |
Exposes ldk-node's unified payment send API, supporting BIP 21 URIs, BIP 353 Human-Readable Names, BOLT11 invoices, and BOLT12 offers. Adds a `pay` CLI command as the primary way to send payments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
valentinewallace
approved these changes
Mar 20, 2026
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_cli_pay() { |
Contributor
There was a problem hiding this comment.
I guess if we tested BIP 353, it might be too flaky with the way github CI is?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes ldk-node's unified payment send API, supporting BIP 21 URIs, BIP 353 Human-Readable Names, BOLT11 invoices, and BOLT12 offers. Adds a
payCLI command as the primary way to send payments.