Custom tlvs#223
Open
Billa05 wants to merge 4 commits into
Open
Conversation
|
I've assigned @benthecarman as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #217.
Exposes
CustomTlvRecordthrough the gRPC API (LDK Node already supports it under the hood):types.CustomTlvRecord { uint64 type_num; bytes value; }repeated custom_tlvsfield onSpontaneousSendRequestrepeated custom_recordsfield onPaymentReceivedandPaymentClaimable--custom-tlv <type_num>:<hex_value>flag (repeatable) onldk-server-cli spontaneous-sendStrictly wire-additive, no new dependencies. Unit tests cover the proto <-> ldk-node conversions and the
PaymentClaimableproto build,e2e-tests::test_cli_spontaneous_send_with_custom_tlvsdrives the full CLI round-trip.Note: the receive path round-trips odd-type TLVs only. LDK Node's spontaneous-receive uses
claim_funds(preimage)rather thanclaim_funds_with_known_custom_tlvs, so BOLT 4 rejects even-type TLVs at the receiver. Inherited from the pinnedldk-noderevision, this surface will support even types automatically once upstream changes that.