Add fuzzing coverage for BOLT11 invoice deserialization #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New file needs to be added to the rustfmt exception list to fix CI. |
TheBlueMatt
force-pushed
the
2024-04-fuzz-bolt11
branch
from
c372854
to
f55f0bf
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
==========================================
+ Coverage 89.14% 90.89% +1.74%
==========================================
Files 118 118
Lines 97850 103621 +5771
Branches 97850 103621 +5771
==========================================
+ Hits 87230 94188 +6958
+ Misses 8376 7005 -1371
- Partials 2244 2428 +184 ☔ View full report in Codecov by Sentry. |
When parsing lightning-invoice HRPs we want to read them char-by-char, tracking at which offset different fields were. Prior to this commit this was done first by reading char-by-char and then by indexing using the byte offset which works for ASCII strings but fails on multi-byte characters. This commit fixes this issue by simply always walking byte-by-byte and rejecting multi-byte characters which don't belong in HRPs.
TheBlueMatt
force-pushed
the
2024-04-fuzz-bolt11
branch
from
f55f0bf
to
8db1226
Compare
valentinewallace
approved these changes
May 8, 2024
jkczyz
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and fix a bug with wrong byte read offsets.