Return an error when the intercept SCID is unknown to the LSPS2 service #4160
Conversation
HTLCs can be intercepted for multiple reasons unrelated to this handler: - Other HTLC interceptors might have generated intercept SCIDs. - The SCID of a closed channel might have fallen into the fake SCID namespace. The LSPS2 handler needs to indicate whether the specific SCID was known to it, so other handlers can be called or the HTLC can be failed back.
|
👋 Thanks for assigning @tnull as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4160 +/- ##
==========================================
- Coverage 88.77% 88.74% -0.04%
==========================================
Files 180 180
Lines 136622 136624 +2
Branches 136622 136624 +2
==========================================
- Hits 121293 121252 -41
- Misses 12517 12559 +42
- Partials 2812 2813 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LGTM but would like @martinsaposnic or @tnull to have a look since I haven't reviewed lightning-liquidity code
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
5 participants
HTLCs can be intercepted for multiple reasons unrelated to this handler:
The LSPS2 handler needs to indicate whether the specific SCID was known to it, so other handlers can be called or the HTLC can be failed back.
Returning a boolean is an option as well.
This is a continuation of lightningdevkit/lightning-liquidity#138.