Skip to content

Return an error when the intercept SCID is unknown to the LSPS2 service #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

Return an error when the intercept SCID is unknown to the LSPS2 service #4160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lightning-liquidity/src/lsps2/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,7 +981,7 @@ where
/// Will generate a [`LSPS2ServiceEvent::OpenChannel`] event if the intercept scid matches a payment we are expected
/// and the payment amount is correct and the offer has not expired.
///
/// Will do nothing if the intercept scid does not match any of the ones we gave out.
/// Will return an error if the intercept scid does not match any of the ones we gave out.
///
/// [`Event::HTLCIntercepted`]: lightning::events::Event::HTLCIntercepted
/// [`LSPS2ServiceEvent::OpenChannel`]: crate::lsps2::event::LSPS2ServiceEvent::OpenChannel
Expand Down Expand Up @@ -1067,6 +1067,10 @@ where
});
},
}
} else {
return Err(APIError::APIMisuseError {
err: format!("Unknown scid provided: {}", intercept_scid),
});
}

if let Some(counterparty_node_id) = should_persist {
Expand Down