Add LDK Node integration test #4206
Conversation
|
👋 Thanks for assigning @joostjager as a reviewer! |
tnull
force-pushed
the
2025-11-ldk-node-integration-test
branch
3 times, most recently
from
9425d6b to
816b70e
Compare
We add a simple workflow to our CI that runs `cargo check` on LDK Node to ensure LDK didn't introduce breaking API changes. The idea here is to catch breaking changes early, and encourage to fix them in LDK or LDK Node `main` ASAP. In the future we might want to extend this to run the full test suite, once we whack-a-moled a few more of LDK Node's flaky tests.
tnull
force-pushed
the
2025-11-ldk-node-integration-test
branch
from
816b70e to
f50ea31
Compare
| @@ -0,0 +1,44 @@ | |||
| name: LDK Node Integration Tests | |||
There was a problem hiding this comment.
Use something like "LDK Node build compatibility check" for now? Can update the name once the integration tests are actually ran.
There was a problem hiding this comment.
Hmm, I intentionally left it more general for now.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
=======================================
Coverage 89.29% 89.30%
=======================================
Files 180 180
Lines 137913 137913
Branches 137913 137913
=======================================
+ Hits 123144 123157 +13
+ Misses 12154 12147 -7
+ Partials 2615 2609 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Will just land this, as it's simple enough and we can make further changes. |
3 participants
We add a simple workflow to our CI that runs
cargo checkon LDK Node to ensure LDK didn't introduce breaking API changes.The idea here is to catch breaking changes early, and encourage to fix them in LDK or LDK Node
mainASAP.In the future we might want to extend this to run the full test suite, once we whack-a-moled a few more of LDK Node's flaky tests.