Skip to content

Fix build warnings under rustc 1.75.0 #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
+4 −3
Merged

Fix build warnings under rustc 1.75.0 #4212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73820ae
Fix compiler warning
jkczyz Nov 5, 2025
2338805
Fix unused_mut warning under --cfg=c_bindings
jkczyz Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lightning/src/offers/offer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ impl MetadataStrategy for DerivedMetadata {}

macro_rules! offer_explicit_metadata_builder_methods {
(
$self: ident, $self_type: ty, $return_type: ty, $return_value: expr
$self: ident, $self_type: ty, $return_type: ty, $return_value: expr $(, $mut: tt)?
) => {
/// Creates a new builder for an offer using the `signing_pubkey` for signing invoices. The
/// associated secret key must be remembered while the offer is valid.
Expand Down Expand Up @@ -259,7 +259,7 @@ macro_rules! offer_explicit_metadata_builder_methods {
///
/// Successive calls to this method will override the previous setting.
pub fn metadata(
mut $self: $self_type, metadata: Vec<u8>,
$($mut)? $self: $self_type, metadata: Vec<u8>,
) -> Result<$return_type, Bolt12SemanticError> {
$self.offer.metadata = Some(Metadata::Bytes(metadata));
Ok($return_value)
Expand Down Expand Up @@ -523,7 +523,7 @@ impl<'a, M: MetadataStrategy, T: secp256k1::Signing> OfferBuilder<'a, M, T> {
}

impl<'a> OfferBuilder<'a, ExplicitMetadata, secp256k1::SignOnly> {
offer_explicit_metadata_builder_methods!(self, Self, Self, self);
offer_explicit_metadata_builder_methods!(self, Self, Self, self, mut);
}

impl<'a, T: secp256k1::Signing> OfferBuilder<'a, DerivedMetadata, T> {
Expand Down
1 change: 1 addition & 0 deletions lightning/src/sync/debug_sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ use parking_lot::Condvar as StdCondvar;
use parking_lot::Mutex as StdMutex;
use parking_lot::MutexGuard as StdMutexGuard;

#[cfg(feature = "std")]
pub use parking_lot::WaitTimeoutResult;

use crate::prelude::*;
Expand Down