[0.2-bindings] Make AttributionData actually pub since its used in the public API
#4269
+112
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AttributionData` is a part of the public `UpdateFulfillHTLC` and `UpdateFailHTLC` messages, but its not actually `pub`. Yet again re-exports bite us and leave us with a broken public API - we ended up accidentally sealing `AttributionData`. Instead, here, we just make `onion_utils` `pub` so that we avoid making the same mistake in the future. Note that this still leaves us with arather useless public `AttributionData` API - it can't be created, updated, or decoded, it can only be serialized and deserialized, but at least it exists.
|
I've assigned @valentinewallace as a reviewer! |
valentinewallace
approved these changes
Dec 9, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
TheBlueMatt
merged commit 25236b0
into
lightningdevkit:0.2-bindings
1 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.2-bindings version of #4268. No reason to wait for a full backport to 0.2 cause its gonna conflict heavily with what's already in 0.2-bindings.
AttributionDatais a part of the publicUpdateFulfillHTLCandUpdateFailHTLCmessages, but its not actuallypub. Yet again re-exports bite us and leave us with a broken public API - we ended up accidentally sealingAttributionData.Instead, here, we just make
onion_utilspubso that we avoid making the same mistake in the future.Note that this still leaves us with arather useless public
AttributionDataAPI - it can't be created, updated, or decoded, it can only be serialized and deserialized, but at least it exists.Best reviewed with
--color-moved --color-moved-ws=ignore-space-change.