Skip to content

Conversation

@joostjager
Copy link
Contributor

Another small step towards better readability.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 10, 2025

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@joostjager joostjager force-pushed the remove-handle-error-macro branch from c0d2377 to deac317 Compare December 10, 2025 14:17
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 89.52381% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.38%. Comparing base (ef844f2) to head (deac317).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 89.52% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4273      +/-   ##
==========================================
+ Coverage   89.34%   89.38%   +0.03%     
==========================================
  Files         180      180              
  Lines      139302   139366      +64     
  Branches   139302   139366      +64     
==========================================
+ Hits       124466   124568     +102     
+ Misses      12212    12208       -4     
+ Partials     2624     2590      -34     
Flag Coverage Δ
fuzzing 35.18% <77.14%> (+0.09%) ⬆️
tests 88.71% <89.52%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joostjager joostjager marked this pull request as ready for review December 10, 2025 17:53
@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@wpaulino wpaulino merged commit 765e43d into lightningdevkit:main Dec 10, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants