[0.2] Clarify splicing feature flag requirements #4274
Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
|
Once this lands, I'll open a PR against main with just the documentation update. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.2 #4274 +/- ##
==========================================
- Coverage 88.87% 88.86% -0.01%
==========================================
Files 180 180
Lines 138117 138117
Branches 138117 138117
==========================================
- Hits 122752 122743 -9
- Misses 12543 12545 +2
- Partials 2822 2829 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
changed the title
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Can you just open this against main to begin with? We have the release notes on main too so the entire commit needs to go upstream. Seems more sensible to push it upstream then backport rather than start on 0.2.
| /// Initiating a splice requires that the channel counterparty supports splicing. Existing | ||
| /// channels can be spliced, as long as a reconnection with the counterparty occurred after they |
There was a problem hiding this comment.
| /// Initiating a splice requires that the channel counterparty supports splicing. Existing | |
| /// channels can be spliced, as long as a reconnection with the counterparty occurred after they | |
| /// Initiating a splice requires that the channel counterparty supports splicing. Any | |
| /// channel (no matter the type) can be spliced, as long as a reconnection with the counterparty occurred after they |
| /// enabled splicing. All channel types can be spliced, namely legacy, anchor, and | ||
| /// zero-fee-commitment channels. |
There was a problem hiding this comment.
Can we condense this a bit?
| /// enabled splicing. All channel types can be spliced, namely legacy, anchor, and | |
| /// zero-fee-commitment channels. | |
| /// enabled splicing. |
| Support for accepting splices is gated on | ||
| `UserConfig::reject_inbound_splices`. Outbound splices can be initiated with | ||
| `ChannelManager::splice_channel`. | ||
| `ChannelManager::splice_channel`. Initiating a splice requires that the |
There was a problem hiding this comment.
I'm actually not really sure about including yet more detail in the release notes here. Its already super long and we don't generally include low-level details here unless missing the details will leave applications broken.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
3 participants
No description provided.