BOLT 12: Validate bech32 padding per BIP-173#4349
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Jan 26, 2026
Merged
Conversation
|
I've assigned @joostjager as a reviewer! |
vincenzopalazzo
force-pushed
the
macros/bolt12-invalid-padding-test-vector
branch
from
05d2d4b to
051e3d1
Compare
Add validation for bech32 padding in BOLT 12 offer parsing per BIP-173 which states: "Any incomplete group at the end MUST be 4 bits or less, MUST be all zeroes, and is discarded." This adds a test vector from the BOLT specification that ensures offers with invalid padding (exceeding the 4-bit limit) are properly rejected. Previously, LDK would accept offers with invalid bech32 padding. This was identified through differential fuzzing across Lightning implementations (see lightning/bolts#1312). The fix calls `validate_segwit_padding()` from the bech32 crate during offer parsing, and introduces a new `InvalidPadding` variant to `Bolt12ParseError` to surface these errors. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/bolt12-invalid-padding-test-vector
branch
from
051e3d1 to
cea1c72
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4349 +/- ##
=======================================
Coverage 86.08% 86.08%
=======================================
Files 156 156
Lines 102416 102428 +12
Branches 102416 102428 +12
=======================================
+ Hits 88165 88180 +15
+ Misses 11759 11756 -3
Partials 2492 2492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add validation for bech32 padding in BOLT 12 offer parsing per BIP-173 which states:
Previously, LDK would accept offers with invalid bech32 padding, while other implementations (Lightning-kmp, Eclair) correctly reject them. This was identified through differential fuzzing across Lightning implementations.
Changes
validate_segwit_padding()from the bech32 crate during offer parsingInvalidPaddingerror variant toBolt12ParseErrorReferences