Skip to content

Conversation

@wpaulino
Copy link
Contributor

This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.

Depends on #4336.

@wpaulino wpaulino added this to the 0.3 milestone Jan 28, 2026
@wpaulino wpaulino self-assigned this Jan 28, 2026
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 28, 2026

👋 Thanks for assigning @jkczyz as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 76.96737% with 120 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.08%. Comparing base (8cdc86a) to head (9933019).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 75.24% 66 Missing and 9 partials ⚠️
lightning/src/ln/channelmanager.rs 79.62% 35 Missing and 9 partials ⚠️
lightning/src/ln/interactivetxs.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4355      +/-   ##
==========================================
- Coverage   86.53%   86.08%   -0.46%     
==========================================
  Files         158      156       -2     
  Lines      103190   102620     -570     
  Branches   103190   102620     -570     
==========================================
- Hits        89300    88340     -960     
- Misses      11469    11775     +306     
- Partials     2421     2505      +84     
Flag Coverage Δ
fuzzing ?
tests 86.08% <76.96%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt
TheBlueMatt previously approved these changes Jan 28, 2026
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.

This was linked to issues Jan 29, 2026
@TheBlueMatt
Copy link
Collaborator

Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well.

@wpaulino
Copy link
Contributor Author

Marked this as fixing #3489 and #2088

There's one more case for dual-funding that still needs to be addressed -- the first_per_commitment_point in open_channel2.

@TheBlueMatt
Copy link
Collaborator

Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :)

This commit allows for an async signer to immediately return upon a call
to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial
commitment signatures of an interactively funded transaction, such that
they can call back in via `ChannelManager::signer_unblocked` once the
signatures are ready. This is done for both splices and dual-funded
channels, though note that the latter still require more work to be
integrated. Since `tx_signatures` must be sent only after exchanging
`commitment_signed`, we make sure to hold them back if they're ready to
be sent until our `commitment_signed` is also ready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

async signing completion Async + Fallible Signing

3 participants