-
Notifications
You must be signed in to change notification settings - Fork 435
Support async signing of interactive-tx initial commitment signatures #4355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4355 +/- ##
==========================================
- Coverage 86.53% 86.08% -0.46%
==========================================
Files 158 156 -2
Lines 103190 102620 -570
Branches 103190 102620 -570
==========================================
- Hits 89300 88340 -960
- Misses 11469 11775 +306
- Partials 2421 2505 +84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Easy enough. We should ask claude to add async signing to the chanmon_consistency fuzzer as a followup.
|
Marked this as fixing #3489 and #2088 though we should probably see if we need to address #3109 (review) as well. |
|
Sure but we don't actually do dual-funding yet, so that's just a part of doing dual-funding now :) |
This commit allows for an async signer to immediately return upon a call to `EcdsaChannelSigner::sign_counterparty_commitment` for the initial commitment signatures of an interactively funded transaction, such that they can call back in via `ChannelManager::signer_unblocked` once the signatures are ready. This is done for both splices and dual-funded channels, though note that the latter still require more work to be integrated. Since `tx_signatures` must be sent only after exchanging `commitment_signed`, we make sure to hold them back if they're ready to be sent until our `commitment_signed` is also ready.
9933019 to
eb9fc0c
Compare
Depends on #4336.