Add CI job to report main branch build failures via GitHub issues#4418
Draft
joostjager wants to merge 1 commit intolightningdevkit:mainfrom
Draft
Add CI job to report main branch build failures via GitHub issues#4418joostjager wants to merge 1 commit intolightningdevkit:mainfrom
joostjager wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Hi! I see this is a draft PR. |
0709866 to
d002d08
Compare
Uses jayqi/failed-build-issue-action to automatically create or comment on a "build failed" issue when any CI job fails on the main branch. Assigns the created issue to the committer who triggered the failure. Pins the action to a specific commit SHA for supply chain safety. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d002d08 to
4641656
Compare
Contributor
Author
|
For |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4418 +/- ##
==========================================
- Coverage 86.07% 86.06% -0.01%
==========================================
Files 156 156
Lines 103442 103442
Branches 103442 103442
==========================================
- Hits 89033 89029 -4
- Misses 11894 11900 +6
+ Partials 2515 2513 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
notify-failurejob to the main CI workflow (build.yml) that automatically creates a GitHub issue when the main branch build fails. Uses jayqi/failed-build-issue-action to create or comment on an issue with the "build failed" label. The job triggers onmainbranch pushes when at least one job inbuild.ymlhas failed.The new job depends on all existing jobs in
build.ymland runs after they complete. If any job fails, it either creates a new issue with the "build failed" label or adds a comment to an existing open issue with that label. Closing the issue signals the problem is resolved; subsequent failures will create a fresh issue. The created issue is automatically assigned to the committer whose push triggered the failure.Note that this only covers jobs in
build.yml. Other workflows that run on main pushes (semver.yml,ldk-node-integration.yml) are not covered yet, as GitHub Actionsneedscannot cross workflow boundaries. Expanding coverage would require some restructuring (e.g., converting them to reusable workflows or duplicating the notification job).The action is pinned to a specific commit SHA rather than a mutable version tag to prevent supply chain attacks. Its permissions are scoped to
issues: writeonly, so the token cannot be used to push code, modify workflows, or access secrets.Tested on the main branch of my fork by deliberately breaking the
rustfmtjob. The action successfully created an issue: joostjager#3