Skip to content

chainmon: fixup stale docs mentioning removed funding_txo params#4538

Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
lexe-app:phlip9/fix-docs
Apr 2, 2026
Merged

chainmon: fixup stale docs mentioning removed funding_txo params#4538
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
lexe-app:phlip9/fix-docs

Conversation

@phlip9
Copy link
Copy Markdown
Contributor

@phlip9 phlip9 commented Apr 2, 2026

The ChainMonitor's external interface changed it's "primary key" from funding txo -> channel id, but some fn docs didn't get updated.

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 2, 2026

👋 I see @wpaulino was un-assigned.
If you'd like another reviewer assignment, please click here.

@ldk-claude-review-bot
Copy link
Copy Markdown
Collaborator

No issues found.

The PR correctly updates three stale doc comments in chainmonitor.rs to reflect that functions now take ChannelId instead of a funding outpoint. All three changes are accurate:

  • get_monitor (line 694): takes channel_id: ChannelId
  • list_monitors (line 710): returns Vec<ChannelId>
  • channel_monitor_updated (line 767): takes channel_id: ChannelId

@ldk-reviews-bot ldk-reviews-bot requested a review from wpaulino April 2, 2026 19:47
Copy link
Copy Markdown
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@TheBlueMatt TheBlueMatt removed the request for review from wpaulino April 2, 2026 20:05
@TheBlueMatt TheBlueMatt merged commit 2adb690 into lightningdevkit:main Apr 2, 2026
20 of 22 checks passed
@phlip9 phlip9 deleted the phlip9/fix-docs branch April 2, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants