Document that LSPS5 services should double-check the destination#4557
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Apr 13, 2026
Merged
Document that LSPS5 services should double-check the destination#4557tnull merged 1 commit intolightningdevkit:mainfrom
tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
It would be easy to implement an LSPS5 service and forget that the webhook calls are going out based on a URI and headers provided by an untrusted client, so such implementations need to make sure to check if the destination is some internal resource before sending. Reported by Jordan Mecom of Block's Security Team
|
I've assigned @joostjager as a reviewer! |
Comment on lines
+59
to
+61
| /// Obviously as the URL provided here is untrusted you should check whether it would | ||
| /// access any internal or private resources and decline to send the request if it is. | ||
| /// |
Collaborator
There was a problem hiding this comment.
nit: Two small suggestions:
- The trailing "if it is" reads awkwardly — consider "if so" or rewording:
Suggested change
| /// Obviously as the URL provided here is untrusted you should check whether it would | |
| /// access any internal or private resources and decline to send the request if it is. | |
| /// | |
| /// Obviously as the URL provided here is untrusted you should check whether it would | |
| /// access any internal or private resources (SSRF) and decline to send the request if so. | |
| /// |
- This warning is only on the
urlfield doc, which is easy to miss. Consider also adding a brief SSRF note to the variant-level doc block above (around line 35), since that's the first thing developers will read when handlingSendWebhookNotification.
Collaborator
|
This is a documentation-only PR adding an SSRF warning to the
No bugs, security issues, or logic errors — this is a straightforward doc improvement. |
joostjager
approved these changes
Apr 13, 2026
tnull
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be easy to implement an LSPS5 service and forget that the webhook calls are going out based on a URI and headers provided by an untrusted client, so such implementations need to make sure to check if the destination is some internal resource before sending.
Reported by Jordan Mecom of Block's Security Team