Conversation
The build-sync job started resolving hyper-rustls v0.27.8 for the esplora-async-https configuration. That release requires rustc 1.85, but the sync CI job still runs on Rust 1.75.0. Pin hyper-rustls to 0.27.7 when building with rustc older than 1.85, alongside the existing MSRV dependency pins in ci-tests-common.sh. AI tools were used in preparing this commit.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
|
No issues found. This is a straightforward CI pin following the exact same pattern as the existing |
| [ "$RUSTC_MINOR_VERSION" -lt 81 ] && cargo update -p idna_adapter --precise "1.1.0" --quiet | ||
|
|
||
| # Starting with version 0.27.8, the `hyper-rustls` crate has an MSRV of rustc 1.85.0. | ||
| [ "$RUSTC_MINOR_VERSION" -lt 85 ] && cargo update -p hyper-rustls --precise "0.27.7" --quiet |
There was a problem hiding this comment.
Really not loving that we have to start pinning-back rustls-related / potentially security critical dependencies on MSRV.
Ubuntu 26.04 LTS release is just 9 days away (and 25.10 already supports up to rustc 1.88).
Can we rather just already bump our MSRV to 1.85? cc @TheBlueMatt
There was a problem hiding this comment.
Let's at least fix the problem with the pin for now.
There was a problem hiding this comment.
The real solution is bitcoindevkit/rust-esplora-client#180
There was a problem hiding this comment.
Note that hyper-rustls is not rustls itself, its hyper's rustls wraper.
There was a problem hiding this comment.
Note that
hyper-rustlsis not rustls itself, itshyper'srustlswraper.
Ofc, which in turn however will/might restrict the set of compatbile rustls versions.
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
yea, let's just land this until rust-esplora-client can upgrade to bitreq. That'll solve our issue in any case.
5 participants
No description provided.