fuzz: remove splicing blocks in chanmon_consistency_target#4589
Closed
alexgrad42 wants to merge 2 commits into
Closed
fuzz: remove splicing blocks in chanmon_consistency_target#4589alexgrad42 wants to merge 2 commits into
alexgrad42 wants to merge 2 commits into
Conversation
Removed !cfg!(splicing) blocks to enable full coverage of splicing logic during fuzzing. Verified by running the fuzzer for 15 minutes before and after the changes. Fuzzing Validation (chanmon_consistency_target): Metric Before After Change cov 37824 38686 +862 ft 155421 168662 +13241 corp 1545 1851 +306 The increase in coverage confirms that the splicing logic is now reachable and being actively fuzzed.
|
👋 Hi! I see this is a draft PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
==========================================
- Coverage 86.84% 86.22% -0.62%
==========================================
Files 161 159 -2
Lines 109260 109103 -157
Branches 109260 109103 -157
==========================================
- Hits 94882 94077 -805
- Misses 11797 12412 +615
- Partials 2581 2614 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
We are not ready to re-enable this until we fix the issues behind the fuzzer failing, which I am working on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this as a Draft (or WIP) because dependencies might still be pending. However, the code is ready and has been verified with extensive fuzz
Removed !cfg!(splicing) blocks to enable full coverage of splicing logic during fuzzing. Verified by running the fuzzer for 15 minutes before and after the changes.
Fuzzing Validation (chanmon_consistency_target):
The increase in coverage confirms that the splicing logic is now reachable and being actively fuzzed.
Fix for #4581