Skip to content

Allow stdin fuzz targets to suppress logs#4646

Open
joostjager wants to merge 1 commit into
lightningdevkit:mainfrom
joostjager:stdin-fuzz-no-logging
Open

Allow stdin fuzz targets to suppress logs#4646
joostjager wants to merge 1 commit into
lightningdevkit:mainfrom
joostjager:stdin-fuzz-no-logging

Conversation

@joostjager
Copy link
Copy Markdown
Contributor

@joostjager joostjager commented May 29, 2026

Add an environment-variable switch that lets stdin fuzz targets use the dev-null test logger. This keeps direct invocations verbose by default, while external runners can opt into quieter passing-case replays.

I use stdin_fuzz also to run big sets of test cases using a runner that parallelizes and also continues on failure to examine the rest. Cargo test and test_cases dir approach do not work for that. The logging is a big slow down.

Add an environment-variable switch that lets stdin fuzz targets use the
dev-null test logger. This keeps direct invocations verbose by default,
while external runners can opt into quieter passing-case replays.
@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented May 29, 2026

🎉 This PR is now ready for review!
Please choose at least one reviewer by assigning them on the right bar.
If no reviewers are assigned within 10 minutes, I'll automatically assign one.
Once the first reviewer has submitted a review, a second will be assigned if required.

@joostjager joostjager requested a review from TheBlueMatt May 29, 2026 13:46
@joostjager joostjager marked this pull request as ready for review May 29, 2026 13:46
@ldk-claude-review-bot
Copy link
Copy Markdown
Collaborator

Good - the types are compatible. DevNull and Stdout both implement Output + Clone + 'static, and the function accepts Out: test_logger::Output.

This PR is a clean, mechanical change. Every file follows the identical pattern, the template is updated, and no fuzz targets were missed. The DevNull type already existed and is properly implemented.

No issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants